Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/tcp unit tests struct data validationtest(hesai): test interface field value #246

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

Feat/tcp unit tests struct data validationtest(hesai): test interface field value #246

wants to merge 37 commits into from

Conversation

ike-kazu
Copy link
Contributor

PR Type

  • Improvement

Related Links

Description

This branch was created based on feat/tcp-unit-tests.

[Additional function]

  • test each field values

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

mojomex and others added 30 commits November 22, 2024 16:23
@mojomex
feat(loggers): add a new generic dependency-injectable logger class
c97d35e 
Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex
feat(loggers): add a console logger implementation
4d21fe0 
Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex
feat(loggers): add an rclcpp logger implementation
c6fcf9b 
Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex
chore(hesai_hw_interfaces): switch to the new loggers::Logger class, …
3c08c51 
…remove rclcpp dependency 🎉

Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex
feat(udp): a new UDP socket implementation
c59c9bd 
Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex
chore(udp): more error handling and doc comments
31cf927 
Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex
chore(udp): always enable socket reuse
7b01925 
Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex
chore(udp): clean up C-style code
2b10e16 
Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex
chore(udp): remove unnecessary double parens
8e61872 
Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex
feat(udp): use poll to prevent blocking when there is no received data
5e01ad5 
Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex
chore(udp): differentiate between socket and usage-related errors
ad11905 
Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex
feat(udp): allow setting receive buffer size
a8d9f22 
Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex
chore(udp): use uint8_t because std::byte is annoying to refactor int…
72033a7 
…o everywhere

Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex
fix(udp): update state correctly when bind() is called
05bbcbb 
Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex
feat(udp): monitor socket packet drops
cd79905 
Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex
feat(udp): add explicit unsubscribe function to facilitate clean shut…
7431a01 
…down

Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex
chore(expected): add stdexcept include
115e31a 
Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex
feat(udp): report when messages have been truncated
a506366 
Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex
chore(udp): relax some usage requirements
7d2ddca 
Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex
test(udp): add most of the unit tests for udp socket
390930d 
Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex
chore(cspell): add OVFL to dictionary
cda257e 
Signed-off-by: Max SCHMELLER <[email protected]>
@pre-commit-ci @mojomex
ci(pre-commit): autofix
95b8b77
@mojomex
fix(udp): return correctly truncated buffer when oversized packet is …
e2b51eb 
…received

Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex
feat(hesai): add an easier-to-use TCP socket implementation (still us…
7b55ecd 
…es transport_drivers internally)

Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex
chore(hesai): use new TCP implementation and dependency-inject concre…
585f93b 
…te TCP socket

Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex
test(hesai): add basic tests for Hesai's PTC protocol
81ad961 
Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex
WIP
e35b856 
Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex
WIP
2f6e8cd 
Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex
Merge branch 'main' into feat/tcp-unit-tests
8f02df4 
Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex
test(hesai): fix hex parsing
f436ae4 
Signed-off-by: Max SCHMELLER <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ike-kazu @mojomex